doomemacs / doomemacs/core

keybinding overlap between org-roam and sly-mode/sly-mrepl

Open
#6,506 8 comments 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### What did you expect to happen?

sly-mrepl:

Writing code in the repl, switching to normal mode, and pressing return should eval the code, while leaving the cursor in place.

It was behaving as expected before I upgraded to the most recent version (the previous version was ~3 weeks behind main as of time of writing this).

### What actually happened?

Instead of the expected behaviour, the following error shows up:

Wrong type argument: commandp, org-roam-buffer-visit-thing

Pressing return in normal mode, while the cursor is over previously evaluated code, overwrites the currently active region of the repl and moves the cursor, pressing return again sometimes evaluates it as expected, and sometimes gives the same error.

### Describe your attempts to resolve the issue

Disabling org-roam-mode fixes the issue.

### Steps to reproduce

1. Enable org-roam and common-lisp in the init.el
2. Open sly/sly-mrepl (sbcl if it's relevant)
3. Write for example: (+ 1 2)
4. Exit to normal mode
5. Press return

### System Information

https://pastebin.com/T3m9UvXh

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.