doomemacs / doomemacs/core

Zoom.el errors while +popup-mode is enabled

Open
#6,330 1 comment 1 reaction 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### What did you expect to happen?

Enabling `zoom-mode` and `+popup-mode` shouldn't produce any errors.

### What actually happened?

When [zoom-mode](https://github.com/cyrus-and/zoom) and `+popup-mode` are enabled, clicking on popup buffers (e.g. helpful popups) produces the following errors:

```elisp
Error during redisplay: (#[128 "\300\302^B\"\300\301^C\"\210\207" [apply zoom--handler #[128 "\300\301^B\"\210\300\302^B\"\207" [apply redisplay--pre-redisplay-functions ignore nil] 4 nil nil] nil] 5 nil nil] (#)) signaled (wrong-type-argument window-valid-p #)
evil-mouse-drag-region: Wrong type argument: window-live-p, #
```
here is my config for zoom, the same thing that was suggested here https://github.com/hlissner/doom-emacs/issues/2225#issuecomment-568287835 :
```elisp
(use-package zoom
:hook (doom-first-input . zoom-mode)
:config
(setq zoom-size '(0.7 . 0.7)
zoom-ignored-major-modes '(dired-mode vterm-mode help-mode helpful-mode rxt-help-mode help-mode-menu org-mode)
zoom-ignored-buffer-names '("*doom:scratch*" "*info*" "*helpful variable: argv*")
zoom-ignored-buffer-name-regexps '("^\\*calc" "\\*helpful variable: .*\\*" "\\*helpful")
zoom-ignore-predicates (list (lambda () (> (count-lines (point-min) (point-max)) 20)))))
```

### Describe your attempts to resolve the issue

After disabling `+popup-mode` the error no longer happens.

### Steps to reproduce

1. Enable `zoom-mode`
2. Enable `+popup-mode`
3. Open a popup (e.g. `SPC h v` and select a variable)
4. Click on somewhere in the popup
5. Check the `*Messages*` buffer and see the errors.

### System Information

https://pastebin.com/r17xpcYC

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.