doomemacs / doomemacs/core

Vanilla workspaces bindings clash with persp-mode keymap

Open
#5,587 1 comment 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### What did you expect to happen?

`C-c w` to show a consistent set of bindings.

### What actually happened?

`C-c w` shows a (maybe accidental) mix of bindings:

![image](https://user-images.githubusercontent.com/2845433/136124589-27d312bc-efbf-43fd-ac04-b208a459c32a.png)

Notice the ones starting with `persp-`, these ones come from:

```elisp
(setq persp-keymap-prefix (kbd "C-c w"))
```

at the beginning of [+emacs-bindings.el](https://github.com/hlissner/doom-emacs/blob/develop/modules/config/default/%2Bemacs-bindings.el).

It's not only that they look out of place in the menu by not having a proper description, but also that they seem to be random, just leftovers of the keymap.

### Describe your attempts to resolve the issue

I would like to remove the

```elisp
(setq persp-keymap-prefix (kbd "C-c w"))
```

which seems to have no role.

(Also to extend the w keymap a bit by adding `persp-add-buffer` as requested in https://github.com/hlissner/doom-emacs/issues/5570.)

### Steps to reproduce

1. In vanilla doom press `C-c w`.

### System Information

https://pastebin.com/GdZqbAjx

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.