doomemacs / doomemacs/core

Quit dialog fails with incorrect type argument

Open
#5,467 0 comments 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### What did you expect to happen?

Related to #5466. After recreating the bug in that, pressing Cmd-Q and typing `y` in the dialog box should quit Emacs.

### What actually happened?

Emacs did nothing except display the message `Wrong type argument: listp, t`.

Backtrace:

```
Debugger entered--Lisp error: (wrong-type-argument listp t)
image-mode-winprops(nil)
image-mode-window-get(page nil)
pdf-view-bookmark-make-record()
saveplace-pdf-view-to-alist(pdf-view-bookmark pdf-view-bookmark-make-record)
saveplace-pdf-view-to-alist-advice(#f(advice-wrapper :around #f(compiled-function () #) doom--inhibit-saveplace-in-long-files-a))
apply(saveplace-pdf-view-to-alist-advice #f(advice-wrapper :around #f(compiled-function () #) doom--inhibit-saveplace-in-long-files-a) nil)
save-place-to-alist()
save-places-to-alist()
save-place-kill-emacs-hook()
kill-emacs()
save-buffers-kill-emacs(nil)
save-buffers-kill-terminal(nil)
funcall-interactively(save-buffers-kill-terminal nil)
call-interactively(save-buffers-kill-terminal nil nil)
command-execute(save-buffers-kill-terminal)
```

### Describe your attempts to resolve the issue

I tried using sandbox mode, and got identical errors.

### Steps to reproduce

1. Recreate the bug in #5466.
2. Quit Emacs
3. Type `y` in the dialog box
4. Observe

### System Information

https://pastebin.com/q8Y4KgKu

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.