+popup-adjust-margins-h appears to apply margin changes to the window you return to after closing a popup
- Dominant language
- Emacs Lisp
- Stars
- 22.7k
- Forks
- 3.1k
- Avg merge
- 10h 46m
- Merged PRs (30d)
- 4
Description
### What did you expect to happen?
I've been trying out a new matrix client lately, called ement.el. Ement by default uses margins to display usernames on the left and timestamps on the right.
When I close popups, I expect it to leave my other buffers/windows alone.
### What actually happened?
When I have a popup open (usually the result of C-h f or C-h v), and I close it, returning to an Ement buffer, the margins of the Ement window will be set to 0.
### Describe your attempts to resolve the issue
Setting +popup-margin-width to nil resolves the issue by effectively disabling +popup-adjust-margins-h. I suppose another fix would be disabling ui/popups entirely.
### Steps to reproduce
- Install https://github.com/alphapapa/ement.el via its instructions (I also have a local module I've been building with the notion that once dev slows down a bit I could contribute it)
- Connect to a Matrix server
- Open a room
- Open a popup of some kind
- Close the popup
### System Information
https://pastebin.com/Dv8XVYMi
Contributor guide
Assessment
This issue has not been assessed yet.