doomemacs / doomemacs/core

doom upgrade: Open diff in browser -> Bad file descriptor

Open
#5,324 3 comments 1 reaction 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### What did you expect to happen?

When I run `doom upgrade` and agree to view the diff in my browser, I shouldn't see a strange warning about bad file descriptors.

### What actually happened?

Upon `doom upgrade` I'm asked if I'd like to see the diff in my browser. **If I have a browser open** it always sends me an error message that looks like this:

![bad-file-desc](https://user-images.githubusercontent.com/229679/127757178-622c4c72-09d6-4e2b-926c-4b566cd4504d.png)

Although the page opens successfully in the browser anyway.

**If I never had a browser open in the first place** I see no such error.

### Describe your attempts to resolve the issue

_No response_

### Steps to reproduce

1. Have Emacs open and Doom on a non-recent commit.
2. Have a browser open (Firefox?)
3. Run `doom upgrade` (from a `vterm` is how I've been doing it).
4. Agree to view the diff.
5. See the error message.

### System Information

https://pastebin.com/NVpjkfwA

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.