donmccurdy / donmccurdy/glTF-Transform

`dedup` removes Animations in Slotted Action unless `keepUniqueNames` true

Open
#1,806 1 comment 0 reactions 0 assignees View on GitHub
bug needs investigation package:functions
Dominant language
TypeScript
Stars
2k
Forks
206
Avg merge
2d 2h
Merged PRs (30d)
16

Description

Since Blender 4.4, Blender supports GLTF Export for Slotted Actions https://docs.blender.org/manual/en/latest/animation/actions.html

Aka, Object `Hand` Grabs Object `Bottle` used to be two different actions which would have to be played in sync manually, now Bottle Action is a slot in the Hand's Grab Action and they play in sync automatically.

This works great, but `dedup()` removes those "child" slotted actions, removing the Bottle's Animation fully, unless you set `dedup( { keepUniqueNames: true } )`.

I think this is a Bug, as Slotted Actions should not be considered duplicate, even if they are accessed the same way.

**Expected behavior**
Unique Animation data should not be deduped

**Versions:**
- Version: 4.2.1
- Environment: nodeJS

Contributor guide

Open the contributing guide

Research direction

Start at the dedup() entry point and trace how animations are compared, using a Blender 4.4 glTF export with slotted actions as the reproduction case. Check existing dedup tests if available; done means unique slotted animation data remains after dedup() without requiring keepUniqueNames: true.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.