donejs / donejs/generator-donejs

Generator should follow the debugging guide by include include the name/tag as the 0th argument to extended DefineMap (the view model)

Open
#283 0 comments 2 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
9
Forks
7
PR merge metrics
No merged PRs in 30d

Description

The debugging guide recommends naming your `DefineMaps` by putting a string in the 0th argument of the `.extend`.

The app generator includes a conditional import for `can-debug`. This implies that we should be using the new debugging features.

But when I generate a new component, the view model does not include a name for the DefineMap as recommended by the guide.

Per a discussion on slack, we should camelcase the tag (after removing the `-`) and maybe add `VM` at the end. (like so - https://github.com/canjs/can-component/blob/311a68be00f9d7a5ce74f2e68f75ddfbffb1ffef/can-component.js#L175)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.