donejs / donejs/donejs-firebase
donejs add firebase@1 does nothing in bitballs root folder
- Dominant language
- JavaScript
- Stars
- 2
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
@justinbmeyer commented on [Wed Jun 14 2017](https://github.com/donejs/donejs/issues/962)
bitballs root folder is not a donejs project. it's public folder is. If someone runs `donejs add firebase` we should probably give them a warning.
---
@matthewp commented on [Wed Jun 14 2017](https://github.com/donejs/donejs/issues/962#issuecomment-308491547)
Shouldn't this be in donejs/bitballs?
---
@justinbmeyer commented on [Sat Jun 17 2017](https://github.com/donejs/donejs/issues/962#issuecomment-309252094)
No, I think `donejs`'s CLI should warn if its not running in a donejs app. I believe some generators already do. But probably not `donejs add firebase`. It probably belongs in that generator.
---
@matthewp commented on [Sun Jun 18 2017](https://github.com/donejs/donejs/issues/962#issuecomment-309283907)
Can you update the issue description for what change you are proposing to donejs?
---
@frank-dspeed commented on [Mon Jun 19 2017](https://github.com/donejs/donejs/issues/962#issuecomment-309374204)
donejs cli can't warn if on command add in general if not executed in a donejs project as donejs add command creates a donejs project or plugin also.
way to go is to warn only if command is not add app or add plugin
i think in general it should warn only if it trys to execute a donejs-Generator module outside of a donejs project
---
@frank-dspeed commented on [Mon Jul 24 2017](https://github.com/donejs/donejs/issues/962#issuecomment-317407519)
I think this issue is also related and can be closed after this it would fix that https://github.com/donejs/donejs/issues/995
Contributor guide
Assessment
This issue has not been assessed yet.