donejs / donejs/bitcentive

Disallow CORS for SSR server

Open
#84 1 comment 0 reactions 1 assignee Claimed by @marshallswain View on GitHub
Dominant language
JavaScript
Stars
7
Forks
3
PR merge metrics
No merged PRs in 30d

Description

When SSR is turned back on...

We currently have CORS allowed for the rendering server, which is a bad practice.
- [ ] Put all of the API endpoints inside a namespace/prefix like '/v1'
- [ ] Only register the CORS middleware on that namespace.
- [ ] Test
- [ ] Make an API request and check for CORS headers.
- [ ] Make an Ajax request to the homepage and check for the absence of CORS headers.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.