donejs / donejs/bitcentive

components/os-projects

Open
#207 2 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
JavaScript
Stars
7
Forks
3
PR merge metrics
No merged PRs in 30d

Description

- [x] - Be consistent with using `monthlyOSProject` ... `osProjectRef.value.name` -> `monthlyOSProject.osProjectRef.value.name`. I wonder if we should remove the implicit context if `#each/as` is used?
- [x] - `getTotal` should be a method on a `monthlyOSProject`. `{{monthlyOSProject.getTotal.toFixed(2)}}`
- [x] - `contributionMonth.removeMonthlyOSProject(monthlyOSProject)` -> `monthlyOSProject.remove()`
- [x] - `{{#if allOSProjects.ispending}}` spelling?
- [x] - Is it possible to make `selectedOSProjectId` use converters to bind to a `selectedOSProject` that will either be a new OSProject or the right OSProject?
- [x] - `updateNameForMonthlyOSProject` `updateComissionedForMonthlyOSProject ` are these used?
- [x] - `allOSProjects` should just use `OSProject.getList({})`.
- [ ] - `contributionMonth: ContributionMonth`

Probably need to:

- [ ] - Rework this with event streams.
- showAddProject
- cancelAddProject
- projectSelected
- addProject
- project created

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.