donejs / donejs/bitcentive

components/select-contribution-month

Open
#203 0 comments 0 reactions 1 assignee Claimed by @ilyavf View on GitHub
cleanup
Dominant language
JavaScript
Stars
7
Forks
3
PR merge metrics
No merged PRs in 30d

Description

- [x] - Use a converter with `null` instead of `__new__`. (probably not) (https://github.com/donejs/bitcentive/pull/299)
- [x] - `selectedContributionMonthId` should just be a getter / setter. (https://github.com/donejs/bitcentive/pull/299)
- [ ] - Possible to do selectedContributionMonthId with event streams?
- when `new` is selected, create a contribution month. When contribution month is created, update to `new` thing. I'm not sure how to create the new contribution month in this scenario.
- [x] - contributionMonthsPromise should probably be a `value` (#248)
- [x] - lastMonth, nextMonth should use shorthand getter (#248)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.