donahowe / donahowe/AutoStudio
BUG in Transformer2D
- Dominant language
- Jupyter Notebook
- Stars
- 452
- Forks
- 32
- PR merge metrics
- No merged PRs in 30d
Description
Hi there,
First of all thanks for putting out the code, great work! I have noticed one a thing in the code.
In transformer_2d code where update forward method to add prompt/width/height information
https://github.com/donahowe/AutoStudio/blob/9c9820fe48374f2c564b9a7a3348f1abbc118350/model/transformer_2d.py#L213-L227
which we then `refer` in the following attention block
https://github.com/donahowe/AutoStudio/blob/9c9820fe48374f2c564b9a7a3348f1abbc118350/model/transformer_2d.py#L319-L331
However, before that line, this following code gets executed:
https://github.com/donahowe/AutoStudio/blob/9c9820fe48374f2c564b9a7a3348f1abbc118350/model/transformer_2d.py#L285-L302
Since we pass continuous input to this code, the height and width parameters are updated. I was wondering if this was a bug? If width and height meant to be inferred from the tensor dimensions, perhaps we don't need to pass it here?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.