Use proper CSS parser
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 11.2k
- Forks
- 1.8k
- PR merge metrics
- No merged PRs in 30d
Description
The current CSS parser seems very hackish (alot of regular expressions, trims and the like). Why not use a proper CSS parser like https://github.com/sabberworm/PHP-CSS-Parser?
This would solve a lot of problems, as the current parser does not properly support minified CSS (for us it breaks on one-line @page and font-face directives)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the current CSS parsing implementation and the reported failures with minified, one-line @page and font-face directives. Evaluate the proposed sabberworm/PHP-CSS-Parser integration and identify how existing parsing behavior would be preserved. Done means these directives are parsed correctly without breaking current CSS-to-PDF behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100