dolthub / dolthub/dolthub-issues

Improve SQL parser on dolthub

Open
#426 0 comments 0 reactions 2 assignees Claimed by @tbantle22 View on GitHub
enhancement
Dominant language
No language data
Stars
5
Forks
0
PR merge metrics
No merged PRs in 30d

Description

We rely on [`node-sql-parser`](https://github.com/taozhi8833998/node-sql-parser) heavily on dolthub to parse queries on dolthub, mostly for generating queries for the cell buttons and determining whether a query should create a workspace. `node-sql-parser` has a lot of bugs and has led to a bunch of errors on dolthub (specifically in parsing a query to determine if a workspace should be created for mutation queries).

It would be a lot of work to replace `node-sql-parser` and there's a ton of code written around it, but we need to improve. Some options:
1. Fork `node-sql-parser`, find a bunch of mysql queries we can test against, fix it ourselves
2. Find another sql parser and replace the existing dolthub code

It's not really urgent, but we need a better long term option

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.