dolthub / dolthub/dolthub-issues

Is there 1) a better way of looking at diffs for bounties? And 2) a workflow for preventing person A from nulling the cells of person B

Open
#367 0 comments 0 reactions 1 assignee Claimed by @liuliu-dev View on GitHub
bounties
Dominant language
No language data
Stars
5
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Okay so I got a lot of people climbing deep up my butt about merging a certain PR. Here it was:

https://www.dolthub.com/repositories/onefact/paylesshealth/pulls/34/compare?refName=main

It was homepage URLs from a bunch of hospitals. I thought, based on the PR, that the result would be to add a lot of URLs.

Sidenote: it overwrote a lot of URLs (trivially) which was an issue. But since the ones that were materially changed were big improvements, I elected to keep the whole thing. That was a judgment call.

More importantly: it also NULLed a bunch of other stuff, and that's what I didn't catch. I couldn't see it on the web UI.

do

`dolt diff qurdnbdb80mh9r8h5luf2colvgb9qusv f1he3sr553s52uredq318o4c1sb5u7uk`

to see that it set a lot of chargemaster URLs to NULL. For completeness, here's the summary:

```
dolt diff --summary qurdnbdb80mh9r8h5luf2colvgb9qusv f1he3sr553s52uredq318o4c1sb5u7uk

diff --dolt a/hospitals b/hospitals
--- a/hospitals @ 34furr8cg6kmqssri651pqvj69badgtg
+++ b/hospitals @ vvarbcbm1hkce793803v1ag0i9qgoieb
prev size: 7154, new size: 7154, adds: 0, deletes: 0, modifications: 0
3,380 Rows Unmodified (47.25%)
0 Rows Added (0.00%)
0 Rows Deleted (0.00%)
3,774 Rows Modified (52.75%)
0 Cells Added (0.00%)
0 Cells Deleted (0.00%)
4,311 Cells Modified (10.04%)
(7,154 Row Entries vs 7,154 Row Entries)
```

**Why this is important:** I want to be able to see what's going to happen when I merge a PR

**The problem:** The CLI diff is hard to read and the DoltHub UI doesn't show all the relevant changes.

image

_an example of the diff_

image

_an example showing how cells look when they're nulled_

**The solution:** I don't really know.

1. One idea is to have a button which does a test merge, and then shows me the diff on another screen in the web UI. Without knowing how things work on the backend I don't know if this is a big ask or a small one.
2. Write my own diffing tools to make better sense of the diff table. Maybe open it in a database editor or something.
3. Your suggestion?

Let me know your thoughts.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.