dolthub / dolthub/dolthub-issues
Changing branch on page with url query doesn't maintain query
- Dominant language
- No language data
- Stars
- 5
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
For example, the pull request list page has an option to filter by pull state and search by keyword, both of which add a query to the url. There are two issues here:
1. Filtering pull list with refName query in url removes refName query
- go to https://dolthub.awsdev.ld-corp.com/repositories/dolthub/pdap-datasets/pulls?refName=main
- filter by open PRs results in https://dolthub.awsdev.ld-corp.com/repositories/dolthub/pdap-datasets/pulls?filter=open
- should result in https://dolthub.awsdev.ld-corp.com/repositories/dolthub/pdap-datasets/pulls?refName=main&filter=open
2. Changing branch when filter or search is active removes those queries and replaces with refName query
- go to https://dolthub.awsdev.ld-corp.com/repositories/dolthub/pdap-datasets/pulls?filter=open
- changing branch results in https://dolthub.awsdev.ld-corp.com/repositories/dolthub/pdap-datasets/pulls?refName=andy%2Fdedupe
- should result in https://dolthub.awsdev.ld-corp.com/repositories/dolthub/pdap-datasets/pulls?refName=andy%2Fdedupe&filter=open
We should do an audit of other pages that make use of url queries on the database page and make sure both of these cases are handled correctly
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.