dolthub / dolthub/doltgresql

dolt_merge now impossible with conflicts

Open
#3,315 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.1k
Forks
73
Avg merge
1d 10h
Merged PRs (30d)
129

Description

Due to other recent changes in transaction handling semantics, it's now impossible to resolve merge conflicts in Doltgres, because the `dolt_merge()` function returns an error in that case, which automatically rolls back any in-progress transactions before conflicts can be addressed.

To fix this, we need to change this behavior (dolt_merge() cannot return an error when conflicts are present) at least for Doltgres, and potentially for Dolt as well.

Contributor guide

Open the contributing guide

Research direction

Start at the dolt_merge() entry point and trace how transaction handling treats conflicts in Doltgres. Determine how to preserve an in-progress transaction when conflicts are present, then verify whether the behavior also needs to change for Dolt; done means conflicts can be addressed without the merge automatically rolling back the transaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, postgresql
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.