dolthub / dolthub/dolt

Incorrect nullability in some result set schemas

Open
#9,972 1 comment 1 reaction 0 assignees View on GitHub
correctness customer issue enhancement
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

Due to an omission in result set schema checking in engine tests, there are several queries in engine tests that have an incorrect nullability declared in test expectations or returned.

Example query:

```sql
select sum(1) as s from emptytable
```

The result schema for this query is declared as non-nullable, but this query returns a single null result (correctly).

Due to this oversight in the testing framework, there are many test queries that fail once we add it. We need to test against MySQL and verify which of these queries return nullable result schemas.

Here's a PR with the missing nullability check added.

https://github.com/dolthub/go-mysql-server/pull/3271

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.