dolthub / dolthub/dolt

sqllogic groupby tests have `ONLY_FULL_GROUP_BY` mode turned off

Open
#9,713 1 comment 0 reactions 0 assignees View on GitHub
testing
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

`ONLY_FULL_GROUP_BY` mode was turned off in dolthub/sqllogictest#19

Due to #4998, GroupBy validation was not running for most queries, even with `ONLY_FULL_GROUP_BY` turned on, resulting in us running a lot of queries that otherwise should've given an error. This was fixed in dolthub/go-mysql-server#3166 but caused 1134 sql logic tests to fail since those queries had been expected to run. Upon investigation, it seems that many of these queries failed because they weren't actually valid queries in MySQL with `ONLY_FULL_GROUP_BY` turned on (which is the default). However, since our GroupBy validation is imperfect, there may be some failing queries that shouldn't be failing, but we won't know unless we comb through all of them.

Since it's tedious to go through over a thousand queries to check for MySQL `ONLY_FULL_GROUP_BY` validity, we've decided to turn `ONLY_FULL_GROUP_BY` mode off to continue testing all groupby sql logic queries.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.