dolthub / dolthub/dolt

Query Status incorrectly reported when `dolt sql` is connected to a server.

Open
#9,550 0 comments 0 reactions 1 assignee Claimed by @macneale4 View on GitHub
cli enhancement
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

While a `dolt sql-server` is running, connect to it with `dolt sql` and create a table:

```
db/main> create table t (id int primary key auto_increment, word varchar(40));
Empty set (0.01 sec)
```

That is not correct. If the server isn't running, it reports Query OK:

```
db/main> create table t (id int primary key auto_increment, word varchar(40));
Query OK, 0 rows affected (0.01 sec)
db1/main*>
```

Note that there is a test which should cover this, but currently skips for remote tests:

https://github.com/dolthub/dolt/blob/e777f8b9f4568a9e0cbc9598a7683805c3eda92d/integration-tests/bats/sql-shell.bats#L38

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.