dolthub / dolthub/dolt

Incorrect results when comparing `types.systemSetType` against other types

Open
#8,825 0 comments 0 reactions 1 assignee Claimed by @zachmu View on GitHub
correctness
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 8h
Merged PRs (30d)
120

Description

Dolt:
```sql
tmp/main> select @@sql_mode;
+---------------------------------------------------------------+
| @@sql_mode |
+---------------------------------------------------------------+
| NO_ENGINE_SUBSTITUTION,ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES |
+---------------------------------------------------------------+
1 row in set (0.00 sec)

tmp/main> select @@sql_mode = 0;
+----------------+
| @@sql_mode = 0 |
+----------------+
| false |
+----------------+
1 row in set (0.00 sec)

tmp/main> select @@sql_mode = 'asd';
value asd was not found in the set
```

MySQL:
```sql
mysql> select @@sql_mode;
+---------------------------------------------------------------+
| @@sql_mode |
+---------------------------------------------------------------+
| ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION |
+---------------------------------------------------------------+
1 row in set (0.0005 sec)

mysql> select @@sql_mode = 0;
+----------------+
| @@sql_mode = 0 |
+----------------+
| 1 |
+----------------+
1 row in set, 1 warning (0.0006 sec)
Warning (code 1292): Truncated incorrect DOUBLE value: 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION'

mysql> select @@sql_mode = 'asd';
+--------------------+
| @@sql_mode = 'asd' |
+--------------------+
| 0 |
+--------------------+
1 row in set (0.0015 sec)

```

Related: https://github.com/dolthub/go-mysql-server/pull/2842

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.