dolt fetch --prune doesn't work when sql-server running
- Dominant language
- Go
- Stars
- 24.4k
- Forks
- 873
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 120
Description
see: https://github.com/dolthub/dolt/blob/801a82a3af6e60d688e12238dec22bd5c9ea7e10/go/libraries/doltcore/env/actions/remotes.go#L742
For reasons which are not immediately clear the `dolt fetch --prune` command doesn't seem to actually prune when a sql-server is running. I _think_ the race mentioned in the code above is the reason.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with go/libraries/doltcore/env/actions/remotes.go at the linked code near line 742, then reproduce `dolt fetch --prune` while the SQL server is running and compare it with the server-stopped case. Trace the suspected race and identify the relevant existing tests or entry points. Done means remote-pruned data is actually removed while the SQL server remains running.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, sql
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100