dolthub / dolthub/dolt

Column diff indexed access bugs

Open
#6,021 0 comments 0 reactions 1 assignee Claimed by @zachmu View on GitHub
bug system tables
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 8h
Merged PRs (30d)
120

Description

A recent change expanded how frequently we apply indexedTableAccess, which exposed some brokenness in the `ColumnDiffTable` index access path and overlooked testing. Specifically, we were only lever testing the prepared path, which was not subject to indexed table access.

```diff
@@ -1706,7 +1706,7 @@ func TestColumnDiffSystemTable(t *testing.T) {
}
for _, test := range ColumnDiffSystemTableScriptTests {
t.Run(test.Name, func(t *testing.T) {
- enginetest.TestScriptPrepared(t, newDoltHarness(t), test)
+ enginetest.TestScript(t, newDoltHarness(t), test)
})
}
}
```

Disabling the `sql.IndexAddressable` interface for now, which forces the non-index path.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.