dolthub / dolthub/dolt

Argument parser seems to grab prefix

Closed
#5,414 0 comments 0 reactions 1 assignee Claimed by @zachmu View on GitHub
bug cli
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 8h
Merged PRs (30d)
120

Description

On line https://github.com/dolthub/dolt/blob/be862d796c7be139d73136e1b10515621086778d/go/cmd/dolt/commands/diff.go#L148
Adding the abbreviation `"m"` to the argument `DiffMode` causes `MergeBase` to become an invalid argument.

This changes the line from
```
ap.SupportsString(DiffMode, "", "diff mode", "Determines how to display modified rows with tabular output...
```
to
```
ap.SupportsString(DiffMode, "m", "diff mode", "Determines how to display modified rows with tabular output...
```
It seems like the `"m"` is matching against the first `"m"` in `"merge-base"`, which should not be happening. In either case, this is not the expected behavior, and should be fixed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.