dolthub / dolthub/dolt

Audit how `t.Skip()` is being used in tests

Open
#11,255 3 comments 0 reactions 0 assignees View on GitHub
testing
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

It was discovered in dolthub/go-mysql-server#3607 that the majority of tests in `TestQueryPlans` (test cases in `PlanTests`) were getting skipped because `t.Skip` was being called in the incorrect run. This has since been fixed, but we need to make sure that in our other tests, `t.Skip()` is actually being called in the correct place to avoid skipping tests that aren't supposed to be skipped.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by searching the Go test files for t.Skip() and inspect the TestQueryPlans cases in PlanTests, using the issue that prompted this audit as context. Check that each skip is reached only in the intended test run, and verify that tests are no longer skipped incorrectly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.