dolthub / dolthub/dolt

Rewrite `ShowCharset` node

Open
#11,250 0 comments 0 reactions 0 assignees View on GitHub
analyzer
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

The `ShowCharset` node seems to just be a `SubqueryAlias`-esque wrapper around `information_schema.character_sets`. It breaks a lot of conventions we have around how nodes are structured, and its debug string is effectively a blackbox so it was hard to debug when a filter was pushed down through it.

It might make sense to structure and build `ShowCharset` to be more similar to other `SHOW` nodes and to resolve/fetch `information_schema.character_sets` during rowexec.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing the ShowCharset node with other SHOW nodes and the SubqueryAlias pattern, then trace how information_schema.character_sets is resolved and fetched during rowexec. Done means ShowCharset follows the project's node conventions, has a useful debug string, and preserves filter pushdown behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sql
Domain
database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.