dolthub / dolthub/dolt

Implement `sql` type interfaces for system types

Open
#10,535 2 comments 0 reactions 0 assignees View on GitHub
correctness
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 8h
Merged PRs (30d)
120

Description

`sql.StringType` was implemented for `types.systemStringType` in dolthub/go-mysql-server#3438

We need to do this for other system types (e.g., implementing `sql.NumberType` for `systemIntType`, etc)

This is important to make sure joining/indexing on system variables works correctly (related to #10316)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the prior sql.StringType implementation for types.systemStringType described in dolthub/go-mysql-server#3438, then inspect systemIntType and the other system types. Confirm which sql interfaces each type needs, and verify that joins and indexing on system variables work correctly when the interfaces are implemented.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sql
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.