dolthub / dolthub/dolt

`unnestExistsSubqueries` is a whole mess

Open
#10,494 0 comments 0 reactions 0 assignees View on GitHub
analyzer correctness
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

There's a lot of correctness issues in `unnestExistsSubqueries` but we need a lot more test coverage to verify these correctness issues.
Also too many functions have confusingly similar names.

TODOs added in dolthub/go-mysql-server#3427

`unnestExistsSubqueries` also doesn't work correctly because it runs after we push outerscope filters below the SubqueryAlias (see #10490) (rule runs as part of `resolveSubqueries`). We should rearrange how our rules run but we need to be careful to make sure all the rules still run correctly.

related child issue: #10493

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.