dolthub / dolthub/dolt

Do not fold empty table join for Right Outer and Full Outer Joins

Open
#10,445 0 comments 0 reactions 0 assignees View on GitHub
analyzer bug
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

During [`buildJoin`](https://github.com/dolthub/go-mysql-server/blob/d9c710c32e81425cd9b1e1812a9e8ef751af326b/sql/planbuilder/factory.go#L150), we return an empty table if either side of the join is empty. We don't do this for Left Outer joins with an empty right side, but we also shouldn't do this for Full Outer joins or Right Outer joins with an empty left side.

To avoid checking both left and side sides, we should transpose the tables before checking if the tables are empty.

TODO added in dolthub/go-mysql-server#3419

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.