Support `NATURAL FULL JOIN`
- Dominant language
- Go
- Stars
- 24.4k
- Forks
- 873
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 120
Description
`NATURAL FULL JOIN` are currently incorrectly parsed as `NATURAL RIGHT JOIN` in Vitess, causing it to return incorrect results in GMS/Dolt (#10268). We need to take the following steps:
1. Correctly parse `NATURAL FULL JOIN` in Vitess as a new join type. This will cause GMS to error out as an unsupported join type.
2. Implement support in GMS for `NATURAL FULL JOIN`.
`NATURAL FULL JOIN` is not supported in MySQL, but we do currently support `FULL JOIN`, which MySQL also does not support.
Contributor guide
No contributing guide indexed for this repository
Research direction
No files or tests are named. Start by locating the Vitess parser handling NATURAL joins, then trace the GMS join implementation. Done means NATURAL FULL JOIN is parsed as its own join type and supported in GMS without being treated as NATURAL RIGHT JOIN.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, mysql
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100