dolthub / dolthub/dolt

Support `require_client_cert` in Docker image

Open
#10,130 0 comments 0 reactions 0 assignees View on GitHub
bug customer issue
Dominant language
Go
Stars
24.4k
Forks
873
Avg merge
1d 5h
Merged PRs (30d)
108

Description

The Dolt SQL server Docker image won't currently work with the new `require_client_cert` configuration setting. This is because the Docker image initialization code launches a Dolt SQL server and then uses `dolt sql` to access that server to add or configure users. This is an issue with the new `require_client_cert` feature, because when `dolt sql` connects to that running Dolt SQL server, it doesn't have a client certificate to use.

To fix this, it seems like we need to change the initialization logic in the Docker image so that we no longer rely on running `dolt sql` when the SQL server is running, such as running any `dolt sql` commands before starting the SQL server, or stopping the SQL server and restarting it after running the `dolt sql` commands if we detect the `require_client_certs` mode is enabled.

Related to customer issue: https://github.com/dolthub/dolt/issues/10008

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.