documentcloud / documentcloud/underscore-contrib
_.isInteger([1]) returns true
Open
Nobody has claimed this yet.
breaking change
bug
- Dominant language
- JavaScript
- Stars
- 622
- Forks
- 114
- PR merge metrics
- No merged PRs in 30d
Description
There is an issue with the function predictates isInteger() and isFloat() where a number is passed in an array of length 1.
eg:
_.isInteger([1])
// true
_.isFloat([1.1])
// true
// both should be false.
The fix for this should be pretty easy by just adding if (i === undefined || i === null || i instanceof Array) return false to the top of isNumeric.
This simple gate will block undefined, null and array.
Suggestions?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating isNumeric and its callers, isInteger and isFloat, then reproduce the array examples from the issue. Done means single-element arrays are rejected by both predicates while ordinary integer and float inputs continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100