documentcloud / documentcloud/underscore-contrib
Should containsDuplicates be added?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 622
- Forks
- 114
- PR merge metrics
- No merged PRs in 30d
Description
I'm frequently in need of checking if a list contains duplicates, and think a containsDuplicates mixin might be appropriate in this project. It would be a simple short-circuiting version of _.uniq with the same isSorted and iterator arguments. If it is appropriate, should it be added to a new sub-contrib or do you find one of the existing ones suitable?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the existing contrib organization and Underscore's _.uniq API, including its isSorted and iterator arguments. The issue is done only once the project has decided whether containsDuplicates belongs in an existing or new sub-contrib and has defined the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100