documentcloud / documentcloud/underscore-contrib
_.isPlainObject seems totally broken
Open
Nobody has claimed this yet.
after modules
bug
- Dominant language
- JavaScript
- Stars
- 622
- Forks
- 114
- PR merge metrics
- No merged PRs in 30d
Description
assert(_.isPlainObject({ a: _.isZero }));
assert(_.isPlainObject({ }));
These fail. I can't find any sane value that will pass. Can someone give me a quick sanity check?
Node 0.10, underscore 1.6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two _.isPlainObject assertions in the issue with Node 0.10 and inspect the _.isPlainObject entry point in underscore-contrib. Compare the observed behavior with the function's intended contract; done means the cause is established and the assertions either pass or the expected behavior is clearly documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100