doctrine / doctrine/persistence

Adding not-nullable search methods to ObjectRepository

Open
#23 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
4k
Forks
76
Avg merge
3d 20h
Merged PRs (30d)
2

Description

I'm currently in the process of improving my codebase with static analysis (PHPStan in this case), and I've found an interesting use case to improve the `ObjectRepository` interface: I find it pretty annoying have to specify/check each time that I don't expect null values from my `find()`/`findOneBy()` methods etc, so it would be nice if there was some `get*()` twin methods for which a nullable return would not be allowed.

This is obviously a BC, so it should target 3.0, hence leveraging nullable types from PHP 7.1 it would make really sense.... What do you think?

PS: since we already have doctrine/common#826 doctrine/common#738 etc, maybe we can create a 3.0 milestone?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.