docling-project / docling-project/docling

Pass http client arguments for remote services

Open
#1,547 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
66.4k
Forks
4.8k
Avg merge
3d 4h
Merged PRs (30d)
98

Description

It would be nice to have the ability to pass in arguments to the http client that is used to connect to remote services.

For example, our team has an internal service that needs TLS versions prior to 1.2 disabled, and the standard way to do this would be
```
import ssl
ctx = ssl.create_default_context()
ctx.minimum_version = ssl.TLSVersion.TLSv1_2
```
and then use the newly-created context in the http transport instead of the default one.

I can help contribute a PR for this if this is okay. It should be a simple change of just making sure [extra http_client_params](https://github.com/docling-project/docling/blob/f1658edbad5c7205bb457322d2c89f7f4d8a4659/docling/utils/api_image_request.py#L20) are passed in to this method and all methods that call it

cc @dolfim-ibm

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.