docker / docker/vscode-extension

Recommendations related to used images, given by LSP are less than desirable

Open
#122 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
59
Forks
23
PR merge metrics
No merged PRs in 30d

Description

While dockerizing one of my nodejs application I have occured on following recommendation

Image

In my opinion, this recommendation is not helpful, and may confuse new users of Docker.
First two recommendations are totally incorrect, because I have selected Node 24 for a reason, and it's better to pin to selected version of OS.
Last one is absolute bogus, because compared to selected image is based on different OS, does not pin version, and generally is incompatible with existing setup for Alpine based images (also as plugin has mentioned, slim tag has a lot of more vulnerabilities).

In my opinion there is no real reason to give recommendations to images that are relatively new, do not have any know vulnerabilities. Recommending a different base OS for these kind of image is bad idea too.

Making recommendations based of base layer of image can be a good idea. Scanning for simple "apt" or "apk" Dockerfile can help with decting incompatibilites between tags.

Related #101

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the image recommendation behavior described in this issue and related issue #101; the payload names no source files or tests. Done should mean recommendations avoid unsuitable image substitutions and account for image version, base OS, and compatibility concerns.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, vscode
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.