docker / docker/secrets-engine

[Windows] Encrypted file store stale lock should get auto-recovered

Open
#295 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
91
Forks
16
Avg merge
9h 3m
Merged PRs (30d)
24

Description

The current implementation inside the encrypted file store has an OS file lock to prevent multiple processes from writing to the store. If the lock does not get removed, it could cause UX headache for the user. A recovery strategy is in place on Unix systems, but this does not work on Windows.

There might be an option to mark the file as "delete upon close", which means the lock file wouldn't persist between processes, but it might solve stale locks. We should look into it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name specific files or tests. Start by locating the encrypted file store and comparing its Windows lock handling with the Unix recovery strategy; investigate whether delete-on-close addresses stale locks. Done means a stale lock can be recovered on Windows without preventing later processes from using the store.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.