docker / docker/scout-action

feature request: do not leak image names that use secrets in github comments

Open
#6 1 comment 0 reactions 1 assignee View on GitHub

@mcapell is already working on this.

Since Jul 12, 2023.

enhancement upstream
Dominant language
JavaScript
Stars
141
Forks
53
PR merge metrics
No merged PRs in 30d

Description

If the image uses a secret the value of the secret is leaked in the github comment.

In the example image below the image reference leaks the value of secrets (if they are used for the image name).
In case a secret is used as part of the image name the image reference should display *** for the secrets instead of leaking them.

some examples: ***/scout-demo-service:main, docker/scout-demo-service:***, ***/***:latest

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.