docker / docker/docker-py

Option to report progress while building context

Open
#376 9 comments 18 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement kind/feature-request
Dominant language
Python
Stars
7.2k
Forks
1.7k
Avg merge
13d 8h
Merged PRs (30d)
2

Description

When building an exceptionally large context, there is no way to report progress. I'd opt to add an option to the util's make context method of progress=False, so that people can manually call the function and set progress=True if they desire it.

To see the problem in action, use this repo (note the docker branch) and run toolset/run-tests.py --install server --docker --test '' (you will need python 2.7 and the requirements listed here. Building teh context can sometimes take up to 15 minutes (note: this is on an NFS filesystem which is notoriously slow when tarring a lot of small files) and normally takes about 5 minutes (on my local SSD)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the util's make context method from the docker-py codebase and reproduce the slow build with the referenced toolset/run-tests.py command. Add the requested opt-in progress behavior and verify that callers can choose whether progress is reported while building the context.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
api, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.