Building images fails on auth errors even when auth is not required
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
The Problem
When running DockerClient.images.build(...), if a StoreError is raised when running AuthConfig._resolve_authconfig_credstore (link) when trying to create auth headers for the build request, the whole command fails.
For my specific example, I have gcloud auth artifacts on my local machine that require login once per day - if I have not logged in and try to build a publicly accessible image, that build will still fail since docker-credentials-gcloud get exits non-zero by prompting me to log in again, even though that auth is not required.
Proposed Solution
Either:
- try/except each call to
_resolve_authconfig_credstoreinget_all_credentials(link and link) and just don't add them toauth_dataif the call errors - do not raise a DockerExecption from the
StoreErrorin _resolve_authconfig_credstore and treat it the same as aCredentialsNotFounderror (I could see this breaking other things)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read docker/auth.py around _resolve_authconfig_credstore and get_all_credentials, then trace how DockerClient.images.build uses the resulting auth data. Reproduce a public image build with an auth credential-store error and verify that the build no longer fails when those credentials are not required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- authentication, build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100