CancellableStream returned by docker_client.api.exec_start does not adequately release resources when closed, causing "I/O operation on closed file" errors
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
CancellableStream returned by docker_client.api.exec_start does not adequately release resources when closed, this leads to errors during python shutdown such as this:
File "/usr/lib/python3.13/site-packages/urllib3/response.py", line 1113, in close
self._fp.close()
File "/usr/lib/python3.13/http/client.py", line 432, in close
super().close() # set "closed" flag
File "/usr/lib/python3.13/http/client.py", line 445, in flush
self.fp.flush()
ValueError: I/O operation on closed file.
I believe this is related, if not the same issue, as: https://github.com/docker/docker-py/issues/3282
urllib3 Response objects need to be explicitly closed or they risk causing the problems above on exit.
(I will propose a patch shortly)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at docker_client.api.exec_start and trace how the returned CancellableStream owns and closes its urllib3 Response. Confirm the close path releases the response cleanly, then verify that shutting down after closing the stream no longer raises the reported I/O error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100