Support for platform in client.images.api.push
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
API version v1.48 accepts platform argument as parameter to be passed to /images/{name}/push but it is not implemented in image.py.
Below function should accept platform i.e JSON-encoded OCI platform to select the platform-variant to push:
def push(self, repository, tag=None, stream=False, auth_config=None,
decode=False):
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the push implementation in image.py around the linked client.images.api.push definition, and compare it with the Docker Engine API v1.48 ImagePush reference. Done means the method accepts the platform argument and passes it to /images/{name}/push; check the existing image API tests for the appropriate validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- api
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100