docker / docker/docker-py

`UnixHTTPConnectionPool` does not update the number of connections in the pool

Open
#3,311 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
1.7k
Avg merge
13d 8h
Merged PRs (30d)
2

Description

Observed in main (current latest commit db7f8b8bb67e485a7192846906f600a52e0aa623)

The method UnixHTTPConnectionPool._new_conn ( here ) does not update the number of connections in the pool in the way that the parent HTTPConnectionPool in urllib3 does ( here ).

The parent increases the attribure num_connections.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read docker/transport/unixconn.py at UnixHTTPConnectionPool._new_conn, then compare it with the referenced urllib3 HTTPConnectionPool._new_conn implementation. Confirm that the pool's connection count is updated consistently, and verify the change against the existing project tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
backend, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.