`container.stop` and `container.restart` are missing the `signal` argument
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
Both stop and restart have supported customizing the signal that is sent to the container since api version v1.42 but it seems that it has not been added here. It would be very helpful if it could be added.
I would have a crack at it but I am not very familiar with writing unit tests. I saw that it is implemented for kill so it might not be too hard but I'm not sure.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the container.stop and container.restart entry points and compare their argument handling with the existing container.kill implementation, which already supports signal. Add matching signal support for both methods and unit-test that the value is passed through for Docker Engine API v1.42 and later.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100