docker / docker/docker-py

Support --stop-timeout in create and run request

Open
#3,168 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
1.7k
Avg merge
13d 8h
Merged PRs (30d)
2

Description

Issue https://github.com/docker/docker-py/issues/2449 was closed without merging the PR (https://github.com/docker/docker-py/pull/2909) . So this parameter is still missing.

Original issue:

API 1.25 added the --stop-timeout to the run command. It needs to be added to the docker API. https://docs.docker.com/engine/api/v1.25/#

Otherwise I received the following error:
TypeError: run() got an unexpected keyword argument 'stop_timeout'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Python library's run() and create request entry points and compare their supported parameters with the Docker Engine API v1.25 documentation. Verify that stop_timeout is accepted for both requests and that the reported TypeError no longer occurs. Confirm the behavior against the API's stop-timeout definition.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.