docker / docker/docker-py

Feature Request: Could container.attrs['Config']['Volumes'] return an empty list instead of None

Open
#2,632 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
1.7k
Avg merge
13d 8h
Merged PRs (30d)
2

Description

I get that not all containers won't have a volume, but it would be nice if that was represented as an empty list instead of None to avoid code that looks like this:

        # kill volumes
        volumes = container.attrs['Config']['Volumes']
        volumes = volumes if volumes is not None else []
        for volume in volumes:
            print("Found a volume; should figure out how to kill it")

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the container.attrs entry point and trace how Config.Volumes is exposed. Verify the representation for containers without volumes, then add or update coverage so the value is an empty list rather than None.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
api, backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.