Not a Contribution: credstore_env not a valid parameter to docker.from_env even though it is listed in docs
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
Not a Contribution!
docker_client = docker.from_env(credstore_env=credentials)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/...../docker/client.py", line 85, in from_env
timeout=timeout, version=version, **kwargs_from_env(**kwargs)
TypeError: kwargs_from_env() got an unexpected keyword argument 'credstore_env'
https://docker-py.readthedocs.io/en/stable/client.html#docker.client.from_env
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in docker/client.py at from_env and kwargs_from_env, then compare their accepted parameters with the from_env documentation at the linked page. Determine which side should reflect the other, and consider the issue resolved when the documented credstore_env behavior no longer produces the reported TypeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100