docker-py implementation of "docker run" doing the wrong thing
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
docker logs can corrupt the logged STDOUT (in case of non-text characters).
I filed a bug report at Docker, but they said that this is not a bug, and that docker logs must not be used to capture STDOUT.
Therefore, the docker-py implementation of "docker run" must be changed to use attach (without logs=1) instead of logs. CLI docker run does the correct thing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in docker/models/containers.py around the docker-py implementation of "docker run" at line 514, and compare its use of logs with the attach behavior described in the issue. Done means the implementation uses attach without logs=1 and preserves binary STDOUT as the Docker CLI does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- api, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100